Add tests for the Translation Memory tab views#4255
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
Collaborator
|
Hey Matt, thanks for the contribution! Will get to this one soon :) |
mathjazz
reviewed
Jun 24, 2026
mathjazz
left a comment
mathjazz
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for adding the test coverage!
The only area called out in #4173 that is not covered here is ajax_translation_memory_upload. It would be great to include at least basic upload tests (permissions, locale scoping, and a successful upload path) before considering the issue fully resolved.
Otherwise, the coverage added for listing, grouping, search, pagination validation, and locale isolation looks aligned with the issue requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit-test coverage for the translation-memory (TM) tab views in the teams app, which previously had no tests exercising their rendering and access rules.
Why this matters
The TM tab views were untested, so regressions in their permission handling or rendering could land unnoticed. This adds targeted tests covering the view responses and the access rules they enforce, raising coverage on a user-facing surface without changing behavior. Reported in #4173.
Testing
The new tests live in
pontoon/teams/tests/test_views.pyand pass under the project's pytest suite (Django was not installed in the authoring environment; the tests follow the existing fixture patterns inpontoon/test/fixtures).Closes #4173